-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test compatibility with actions #230
base: next
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fd12594:
|
I'm unsure which tests should be run in which tool. Both Travis CI and and Circle CI ran |
Codecov Report
@@ Coverage Diff @@
## next #230 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 8 8
Lines 424 424
Branches 148 140 -8
=======================================
Hits 418 418
Misses 6 6 Continue to review full report at Codecov.
|
@Khartir I'd like to have both CircleCI and Travis run the same tests. They have slightly different environments and that has proven to sometimes lead to false negatives but also false positives. In either case there's a problem that wouldn't have surfaced if we only used one. I don't want to spend too much time maintaining them both but if it's not extra work, I'm fine with keeping them both in place. We may eventually migrate to GitHub Actions altogether, but I'm not in a hurry to change anything in our current CI setup if there's no pressing need. |
fd6aa49
to
08a562c
Compare
Description
As mentioned in #214 (comment) this moves the compatibilty tests to Github actions.
There currently seems to be an issue with cashing: Install still runs, although there is a cash hit. This is also the case on the existing action to test the examples.
Breaking changes
Removed
test:compat
and related scripts frompackage.json
Checklist