Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Make TODO chapters in Book as unclickable #996

Closed
wants to merge 2 commits into from

Conversation

s373r
Copy link

@s373r s373r commented Oct 29, 2021

To prevent opening empty pages this PR makes links unclickable from visual and interaction perspectives.

Please check the following preview images:

Before After
before after

Inspired by https://github.com/rust-lang/async-book

@yoshuawuyts
Copy link
Contributor

It seems this might be causing CI to fail; if we could fix that we should be good to merge!

@s373r
Copy link
Author

s373r commented Nov 3, 2021

Hello all!

I've made a little investigation why we got a fail as a result of this CI job (and more interested for me why I couldn't get that locally)

Results

Some thoughts

  • Since CI is an internal thing I cannot update the version from 0.3.7 to 0.4.X -- also, I don't know the real reasons why the version is pinned currently (it may be some needed workaround 🤔 )

Possible next steps

  1. The version can be updated if we have no strong reason not to do so

OR

  1. This PR can wait for version updating and I'll update it later if needed

@Fishrock123 & @yoshuawuyts please see ^^^ if something seems unclear feel free to ping me

Anyway I will wait for feedback :)

* No explicit tag means the latest
@s373r
Copy link
Author

s373r commented Nov 11, 2021

Added 40741ff that should fix CI build error

@s373r s373r requested a review from Fishrock123 November 11, 2021 13:21
@joshtriplett
Copy link
Contributor

We still want to pin a version, we should just update the pin from 0.3 to 0.4.

(Also, there's a typo: "mdbookk" should be "mdbook".)

@s373r s373r closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants