Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back draft chapters #1153

Merged
merged 2 commits into from
May 10, 2020
Merged

Bring back draft chapters #1153

merged 2 commits into from
May 10, 2020

Conversation

azerupi
Copy link
Contributor

@azerupi azerupi commented Feb 29, 2020

According to discussion in PR #1109 I have implemented the "draft chapters" by making the path an option. While it works, it feels a lot dirtier with all the if let.

Maybe this version can be improved to remove some of this 'hack' feeling?
I will leave both PRs open so that they can be compared and I leave it to your appreciation which version you want to go with 🙂

ehuss
ehuss reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how it is a toss-up with #1109 which is better. I think this patch is overall smaller, though, so I kinda still lean towards it.

src/book/book.rs Outdated Show resolved Hide resolved
src/book/mod.rs Outdated Show resolved Hide resolved
src/renderer/html_handlebars/search.rs Outdated Show resolved Hide resolved
src/renderer/html_handlebars/hbs_renderer.rs Outdated Show resolved Hide resolved
@ehuss ehuss added this to the 0.4 milestone Mar 9, 2020
@azerupi
Copy link
Contributor Author

azerupi commented Mar 9, 2020

Thanks, those were some really good suggestions 👍

@azerupi azerupi mentioned this pull request Mar 19, 2020
Closed
@azerupi
Copy link
Contributor Author

azerupi commented Mar 23, 2020

Hi @ehuss,
I have made the requested changes, is there anything else?
I see that you have planned this PR for v0.4.0 does this mean that we need to wait before merging?

I will already close the other PR 🙂

@azerupi azerupi mentioned this pull request Mar 23, 2020
Closed
@azerupi azerupi requested a review from ehuss March 23, 2020 10:48
@ehuss ehuss force-pushed the draft-chapters branch from 151229c to 43008ef Compare May 10, 2020 16:04
ehuss
ehuss approved these changes May 10, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@ehuss ehuss merged commit 578e4da into rust-lang:master May 10, 2020
@bryantbiggs bryantbiggs mentioned this pull request May 26, 2020
Closed
@ehuss ehuss mentioned this pull request Jun 7, 2020
Closed
@shilangyu shilangyu mentioned this pull request Jun 25, 2020
Merged
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@ehuss
Merge pull request rust-lang#1153 from azerupi/draft-chapters
748318f 
Bring back draft chapters
@kalindkaria kalindkaria mentioned this pull request Sep 22, 2020
Closed
@s373r s373r mentioned this pull request Nov 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@azerupi @ehuss