Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncAPI 2.6.0 #126

Closed
Pakisan opened this issue Feb 7, 2023 · 6 comments
Closed

AsyncAPI 2.6.0 #126

Pakisan opened this issue Feb 7, 2023 · 6 comments
Assignees
@Pakisan
Labels
enhancement New feature or request

Comments

@Pakisan
Copy link
Member

Pakisan commented Feb 7, 2023 •
edited
Loading

new features:

  • AsyncAPI 2.6.0
  • Objects can be extended - x-*
@Pakisan Pakisan added the enhancement New feature or request label Feb 7, 2023
@Pakisan Pakisan self-assigned this Feb 7, 2023
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 7, 2023
@Pakisan
feat(AsyncAPI 2.6.0): AsyncAPI object
ba2667a 
AsyncAPI object

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 7, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Info object
2288436 
Info object

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 7, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Servers object
c6ab595 
Servers object

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 11, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Channel - Operation
21f77fb 
- Operation draft
- Channel, Message, Operation Bindings draft

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 11, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Channel - Operation
3100101 
- Fixed references to bindings docs
- Fixed bindings' description
- Fixed bindings' extending of wrong *Binding

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 11, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Channel - Operation
7708420 
asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 11, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Channel - Operation
5be24ee 
OneOfMessages test

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 12, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Channel - Parameter
c5f46e3 
asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 12, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Channel - Bindings
fa26600 
asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 12, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Channel
269be51 
asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 14, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Components
d99ad35 
- servers
- serverVariables
- channels
- messages
- parameters
- correlationIds
- operationTraits
- messageTraits
- serverBindings
- channelBindings
- operationBindings
- messageBindings

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 14, 2023
@Pakisan
feat(AsyncAPI 2.6.0): Components
116b466 
securitySchemes

asyncapi#126
Pakisan added a commit to Pakisan/jasyncapi that referenced this issue Feb 15, 2023
@Pakisan
feat(AsyncAPI 2.6.0): AsyncAPI 2.6.0
7f19e1f 
asyncapi#126
This was referenced Feb 15, 2023
Closed
Closed
Closed
Closed
This was referenced Mar 12, 2023
Closed
Closed
Merged
Merged
@Pakisan Pakisan mentioned this issue Mar 21, 2023
Merged
@ctasada
Copy link

ctasada commented Jun 16, 2023

Hi @Pakisan thanks a lot for the efforts to update to the latest AsyncAPI 2.6.0 specification.

When migrating my code to use the newest asyncapi-core/src/main/java/com/asyncapi/v2/_6_0/model/channel/message/Message.java I get different issues related with MessageBinding comparing the code with the one used in asyncapi-core/src/main/java/com/asyncapi/v2/_6_0/model/channel/message/Message.java I see that the new implementation changed the expected contract of private Map<String, ? extends MessageBinding> bindings

Was this change intended? Wouldn't be better to validate that the provided binding does, in fact, extend MessageBinding ?

I'm happy to provide a patch if needed.

@Pakisan
Copy link
Member Author

Pakisan commented Jun 19, 2023

@ctasada hi!

I'll think what is the best variant to fix it. Open to your proposals

springwolf/springwolf-core#201 (comment)

@Pakisan Pakisan mentioned this issue Jun 19, 2023
Merged
6 tasks
@ctasada ctasada mentioned this issue Jun 22, 2023
Closed
@ctasada
Copy link

ctasada commented Jun 22, 2023

@Pakisan I just created a PR with a proposal. If you like this approach I can clean up the PR and extend it to other objects

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Oct 21, 2023
@ctasada
Copy link

ctasada commented Oct 21, 2023

@Pakisan #153 is still pending review

Adding this comment to avoid stale ticket

@github-actions github-actions bot removed the stale label Oct 22, 2023
@Pakisan Pakisan mentioned this issue Feb 15, 2024
Closed
16 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 19, 2024
@Pakisan Pakisan removed the stale label Feb 22, 2024
@Pakisan Pakisan closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pakisan Pakisan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctasada @Pakisan