Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update AsyncAPI spec version to 2.6.0 #201

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

timonback
Copy link
Member

@timonback timonback commented Jun 2, 2023

  • Read the new spec
    • Message#messageId
    • SchemaFormat + Example via annotation
  • Alphabetic sorting of topics
  • Update imports
  • asyncapi.json endpoint

@timonback
Copy link
Member Author

timonback commented Jun 2, 2023

Imports need to be updated as well -> Done

@timonback timonback marked this pull request as draft June 4, 2023 09:43
@timonback timonback force-pushed the chore/update-spec branch 2 times, most recently from c8c3127 to a5b221d Compare June 11, 2023 20:29
@timonback timonback force-pushed the chore/update-spec branch from a5b221d to 21d0cfe Compare June 11, 2023 20:33
@sam0r040
Copy link
Collaborator

@Pakisan With updating from 2.0.0 to 2.6.0 we noticed that the properties for Message and ChannelBinding have changed the value of the Bindings map from an extension of the Binding type to Object. For Example:

private Map<String, ? extends MessageBinding> bindings;

to

private Map<String, Object> bindings;

this requires some casting for us, was this intended? Did you consider using Map<String,?> instead?

@sam0r040 sam0r040 marked this pull request as ready for review June 16, 2023 12:43
@sam0r040 sam0r040 merged commit b9a5cda into springwolf:master Jun 16, 2023
@sam0r040 sam0r040 deleted the chore/update-spec branch June 16, 2023 13:00
@Pakisan
Copy link
Contributor

Pakisan commented Jun 19, 2023

@sam0r040 hi!

I'll think what is the best variant to fix it. Open to your proposals, in related issue

asyncapi/jasyncapi#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants