Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt Kafka bindings to v3 #446

Closed

Conversation

lbroudoux
Copy link
Collaborator

Description

This is the companion PR to asyncapi/bindings#221.

As discussed and proposed here in issue #182, this PR:

Another PR with specific schemas for v2 and v3 is on its way on asyncapi/spec-json-schemas.

Related issue(s)

Relates to asyncapi/bindings#182

@jonaslagoni
Copy link
Member

@lbroudoux you need to re-target the PR to next-major-spec 🙂

@lbroudoux lbroudoux changed the base branch from master to next-major-spec November 9, 2023 19:49
@lbroudoux
Copy link
Collaborator Author

Oops...

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the bindings to be validated as well, you need to adapt:

As well for message, operation and server 🙂

Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com>
@lbroudoux
Copy link
Collaborator Author

Tests are failing but seem normal as http://asyncapi.com/bindings/kafka/v3-0.4.0/server.json is not yet deployed and available.

dalelane
dalelane previously approved these changes Nov 12, 2023
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lbroudoux
Copy link
Collaborator Author

Now replaced by #453

Could you all confirm we can cancel this one?

@dalelane
Copy link
Collaborator

Now replaced by #453

Could you all confirm we can cancel this one?

yeh, makes sense to me

@dalelane dalelane closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants