Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Prebuild binaries #126

Closed
wants to merge 3 commits into from
Closed

Conversation

bendemboski
Copy link

Use prebuild and prebuild-install to enable consumption of prebuilt binaries. This is basically a copy of how node-keytar does it

Ben Demboski added 2 commits August 22, 2019 14:34
This is basically a copy of how node-keytar does it
This test appears to have the same inconsistent behavior issue as the one below
@bendemboski bendemboski force-pushed the prebuild-binaries branch 2 times, most recently from 17d8eec to 0bfcd57 Compare August 31, 2019 06:13
Always prebuild on master/tag builds, but only upload on tag builds
@rsese
Copy link

rsese commented Sep 12, 2019

Thanks for the contribution! Chatted with the other maintainers and while we do see that prebuilt binaries could be generally useful for other applications that use node-spellchecker, it doesn't look like something necessary for Atom in particular (let me know if I'm misunderstanding though). With our current resources and priorities, as much as possible we're not taking on changes that don't directly address some issue/bug in Atom. node-keytar is a bit different right now because it has someone keeping an eye on it consistently.

If things change in the future we could revisit this but for now, because we treat our issues list as the Atom team's backlog, we'll close this out since it's not something the team would work on. But thank you again for the contribution, we do appreciate it.

@rsese rsese closed this Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants