Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix for v8 in node 12. #128

Closed
wants to merge 3 commits into from
Closed

Conversation

goddessfreya
Copy link
Contributor

Signed-off-by: Hal Gentz zegentzy@protonmail.com

βš›πŸ‘‹ Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Copy the correct template for your contribution
  1. Replace this text with the contents of the template
  2. Fill in all sections of the template
  3. Click "Create pull request"

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
@radenkovic
Copy link

just to check if this is going to be merged anytime soon? Thanks!

@johnjjung

This comment has been minimized.

@bigshahan

This comment has been minimized.

@TonyWuu

This comment has been minimized.

@goddessfreya
Copy link
Contributor Author

I'm not exactly sure who still has commit access to this repo and who the maintainers are, so, uhhh, I guess I can try pinging everybody who's ever merged a commit here before?

cc @rafeca @smashwilson @maxbrunsfeld @nathansobo @zcbenz @kevinsawicki @lee-dohm @daviwil @anaisbetts @damieng @joefitzgerald I guess πŸ€·β€β™€οΈ

@bendemboski
Copy link

FYI, for folks waiting for this, I've been maintaining a fork, spellchecker-prebuild that is a drop-in replacement (the same code), but with prebuilt binaries. It has this fix rolled into it, and now has Electron 7-compatible binaries published, so you can use it with Electron 7.

@goddessfreya
Copy link
Contributor Author

Sweet. I was personally planning to maintain a fork at goddessfreya/node-spellchecker until #130 gets merged in. Maybe we can roll our changes in together?

@bendemboski
Copy link

Yeah, I'm game, although unsure of the practical aspects. It looks like I'll be maintaining a prebuild fork indefinitely, and I have spellchecker-prebuild on npm pointing to my fork, so I'm loath to switch off my fork because of the extra work/fiddling it would entail.

Also, I have some hesitation about applying changes before they are released in node-spellchecker because then the versioning story gets confusing, and prebuilds kinda rely on version numbers and releases to function, so it's not as easy to using a git URL or something.

So I'm unsure of how we would do this, although very open to ideas...

@vladimiry
Copy link

vladimiry commented Dec 26, 2019

Btw the fix also works well with Electron v8 (currently 8.0.0-beta.5).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants