Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

Project name is an empty string in editor tests #436

Closed
ddgenome opened this issue Mar 16, 2017 · 2 comments
Closed

Project name is an empty string in editor tests #436

ddgenome opened this issue Mar 16, 2017 · 2 comments
Assignees
@ddgenome
Labels
bug Testing

Comments

@ddgenome
Copy link
Contributor

When executing editor tests, calling project.name() returns an empty string. The project object seems to be valid, you can call name() and files(), which returns all the files as appropriate.

This may be related to #425.
@ddgenome ddgenome self-assigned this Mar 16, 2017
@ddgenome
Copy link
Contributor Author

Looks like the project name is gotten:

https://github.com/atomist/rug/blob/master/src/main/scala/com/atomist/rug/kind/core/ProjectMutableView.scala#L91-L94

which looks like

ProjectMutableView.currentBackingObject
  ArtifactSource.id
    ArtifactSourceIdentifier.name (from ArtifactSourceLocator trait)

When we create the ArtifactSource, we often use a constructor that sets an empty name.

@ddgenome
Copy link
Contributor Author

I have a failing test.

ddgenome pushed a commit that referenced this issue Mar 16, 2017
Ensure test projects have a name
5c5c7a8 
When creating the project artifact for testing, give it a name.

Clean up links in the change log.

Fixes #436
@ddgenome ddgenome mentioned this issue Mar 16, 2017
Merged
ddgenome pushed a commit that referenced this issue Mar 16, 2017
Ensure test projects have a name
eed7d51 
When creating the project artifact for testing, give it a name.

Clean up links in the change log.

Fixes #436
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ddgenome ddgenome

Labels
bug Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddgenome