This repository has been archived by the owner on Mar 19, 2019. It is now read-only.
Project name #437
Merged
Project name #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to merge #435 first, as there are probably conflicts. |
added 3 commits
March 16, 2017 19:12
The project name used by the `generateWith()` testing method was
hardcoded to "project_name". We now require a projectName parameter,
separate from the generator parameters. The signature for
`generateWith()` is now
```typescript
generateWith(gen: ProjectGenerator, projectName: string, params?: {})
```
General cleanup of TypeScript and Gherkin formatting.
Closes #425
When creating the project artifact for testing, give it a name. Clean up links in the change log. Fixes #436
|
#435 has been squash-merged and this has been rebased on it. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure project object has an appropriate name.
Fixes #425 and #436 (in separate commits).
Clean up of TypeScript, Gherkin, and change log.
Make test quieter by removing/commenting out
println's andconsole.log()'s.