Reverted typings fix, added a file move step before publish #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The typings files have, until now, assumed to be in the
./dist/typings
folder, but a recent upgrade to TypeScript caused these files to be emitted to./dist/typings/src
. The path inpackage.json
was not updated until 1.4.1.v1.4.1 fixed the path that typings are included in the packaged build, but could break TypeScript apps that directly import typings for particular classes. For example:
import Auth0Client from "@auth0/auth0-spa-js/dist/typings/Auth0Client";
This PR reverts that path, and adds a pre-publish step that copies the typings files to the right place to maintain backwards compatibility.
References
#259
Testing
Tested by manually running
npm run build
thennpm run prepublishOnly
to test the file move. Confirmed that files once again appear in./dist/typings
.Checklist
master