Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted typings fix, added a file move step before publish #263

Merged
merged 3 commits into from
Oct 30, 2019

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Oct 30, 2019

Description

The typings files have, until now, assumed to be in the ./dist/typings folder, but a recent upgrade to TypeScript caused these files to be emitted to ./dist/typings/src. The path in package.json was not updated until 1.4.1.

v1.4.1 fixed the path that typings are included in the packaged build, but could break TypeScript apps that directly import typings for particular classes. For example:

import Auth0Client from "@auth0/auth0-spa-js/dist/typings/Auth0Client";

This PR reverts that path, and adds a pre-publish step that copies the typings files to the right place to maintain backwards compatibility.

References

#259

Testing

Tested by manually running npm run build then npm run prepublishOnly to test the file move. Confirmed that files once again appear in ./dist/typings.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev requested a review from a team October 30, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants