Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved prepublish script into the prepack stage #264

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Moved prepublish script into the prepack stage #264

merged 2 commits into from
Oct 30, 2019

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Oct 30, 2019 •
edited
Loading

Previously, a script was created to execute at the prepublish stage, but it should actually be executed at the prepack stage. Otherwise, the effects of the script are negated.

Ref: #263

@stevehobbsdev stevehobbsdev requested a review from a team October 30, 2019 21:51
@stevehobbsdev stevehobbsdev added the CH: Fixed PR is fixing a bug label Oct 30, 2019
@stevehobbsdev stevehobbsdev merged commit 7ab81d8 into master Oct 30, 2019
@stevehobbsdev stevehobbsdev deleted the fix/prepublish branch October 30, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehobbsdev @luisrudge