Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use storage when inside the Universal Login Page #889

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

luisrudge
Copy link
Contributor

@luisrudge luisrudge commented Jan 8, 2019

fix #882

Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp changed the title Don't use storage when inside the UNiversal Login Page Don't use storage when inside the Universal Login Page Jan 8, 2019
@luisrudge luisrudge merged commit 9b2a98f into master Jan 10, 2019
@luisrudge luisrudge deleted the fix/dont-use-storage-inside-hlp branch January 10, 2019 14:16
@luisrudge luisrudge added this to the v9.9.0 milestone Jan 10, 2019
luisrudge added a commit that referenced this pull request Jan 21, 2019
luisrudge added a commit that referenced this pull request Jan 21, 2019
* Revert "Add `test:coverage` npm script to check coverage locally (#891)"

This reverts commit 14656e3.

* Revert "Update vulnerable dependencies (#892)"

This reverts commit 8381e4b.

* Revert "Release 9.9.0 (#890)"

This reverts commit 535484f.

* Revert "Don't use storage when inside the UNiversal Login Page (#889)"

This reverts commit 9b2a98f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't use cookies inside the HLP
2 participants