Add test:coverage npm script to check coverage locally
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed there's also the Should we add the |
luisrudge
approved these changes
Jan 14, 2019
luisrudge
added a commit
that referenced
this pull request
Jan 21, 2019
This reverts commit 14656e3.
luisrudge
added a commit
that referenced
this pull request
Jan 21, 2019
* Revert "Add `test:coverage` npm script to check coverage locally (#891)" This reverts commit 14656e3. * Revert "Update vulnerable dependencies (#892)" This reverts commit 8381e4b. * Revert "Release 9.9.0 (#890)" This reverts commit 535484f. * Revert "Don't use storage when inside the UNiversal Login Page (#889)" This reverts commit 9b2a98f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no standard way to check coverage locally.
From the README:
This PR simply adds a
test:coveragenpm script that checks coverage via nyc.Happy to change up the script if there's a different variation you'd like to run. Alternatively, we could remove the above line from the README instead of adding a script.