Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-234: Change ClientMetadata to *map[string]interface{} #120

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Oct 13, 2022

🔧 Changes

Changing the type of Client.ClientMetadata to *map[string]interface{} so we can send values as null, as that's the only way we can remove an old key from the map.

e.g. removing the "faa" key

POST /client
{
  "client_metadata": {
    "foo": "bar",
    "faa": "removeMe"
  }
}

PATCH /client
{
  "client_metadata": {
    "foo": "bar",
    "faa": null
  }
}

GET /client
{
  "client_metadata": {
    "foo": "bar"
  }
}

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Oct 13, 2022
@sergiught sergiught marked this pull request as ready for review October 13, 2022 13:16
@sergiught sergiught requested a review from a team as a code owner October 13, 2022 13:16
@sergiught sergiught force-pushed the patch/DXCDT-235-client-metadata branch from 12cfcb1 to 6197b93 Compare October 13, 2022 16:09
@sergiught sergiught merged commit 832b285 into main Oct 17, 2022
@sergiught sergiught deleted the patch/DXCDT-235-client-metadata branch October 17, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants