Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/3] DXCDT-234: Fix update behavior of client_metadata #362

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Oct 13, 2022

🔧 Changes

To correctly remove a key from the client_metadata object we need to send it as null to the API. So we're fixing the behavior of the client_metadata expand to account for this.

POST /client
{
  "client_metadata": {
    "foo": "bar",
    "faa": "removeMe"
  }
}

PATCH /client
{
  "client_metadata": {
    "foo": "bar",
    "faa": null
  }
}

GET /client
{
  "client_metadata": {
    "foo": "bar"
  }
}

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught changed the title DXCDT-234: Fix update behavior or client_metadata DXCDT-234: Fix update behavior of client_metadata Oct 13, 2022
@sergiught sergiught self-assigned this Oct 13, 2022
@sergiught sergiught force-pushed the patch/DXCDT-234-metadata branch from ef3be75 to 9766f77 Compare October 13, 2022 16:04
@sergiught sergiught force-pushed the patch/DXCDT-234-metadata branch from 9766f77 to 2ec154b Compare October 18, 2022 13:50
@sergiught sergiught changed the title DXCDT-234: Fix update behavior of client_metadata [2/3] DXCDT-234: Fix update behavior of client_metadata Oct 18, 2022
@sergiught sergiught changed the base branch from main to patch/DXCDT-232-waad October 18, 2022 13:51
@sergiught sergiught marked this pull request as ready for review October 18, 2022 13:54
@sergiught sergiught requested a review from a team as a code owner October 18, 2022 13:54
@Widcket
Copy link
Contributor

Widcket commented Oct 19, 2022

CI is failing

…t64 instead of int (#369)

Improve precision of branding theme fields with float64 instead of int
@sergiught
Copy link
Contributor Author

sergiught commented Oct 19, 2022

@Widcket , CI was failing as we needed to merge #369 first. They're cascading as they're all depending on changes from v0.12.0 of the go SDK. All green now -> https://github.com/auth0/terraform-provider-auth0/actions/runs/3278934803/jobs/5397902694

@sergiught sergiught merged commit 9720b84 into patch/DXCDT-232-waad Oct 19, 2022
@sergiught sergiught deleted the patch/DXCDT-234-metadata branch October 19, 2022 05:11
sergiught added a commit that referenced this pull request Oct 19, 2022
…361)

* Bump go-auth0 to v0.12.0

* Add validation on identity_api for waad connections

* [2/3] DXCDT-234: Fix update behavior of client_metadata (#362)

* Fix update behavior or client_metadata

* [1/3] DXCDT-243: Improve precision of branding theme fields with float64 instead of int (#369)

Improve precision of branding theme fields with float64 instead of int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants