generate multiple java files #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://protobuf.dev/reference/java/java-generated/#invocation When the option java_multiple_files = true is enabled, Then the compiler will also create separate .java files for each of the classes/enums which it will generate for each top-level message, enumeration, and service declared in the .proto file. The goal is to have this option stop generating "OuterClass" named classes for better ergonomics.
vroldanbet
force-pushed
the
java-multiple-files-option
branch
from
32e4107
to
bf590f1
Compare
vroldanbet
force-pushed
the
java-multiple-files-option
branch
4 times, most recently
from
45df4f7
to
f7c8b5a
Compare
vroldanbet
force-pushed
the
java-multiple-files-option
branch
2 times, most recently
from
0511c85
to
db4a5c7
Compare
|
Has this change been requested? |
|
@jzelinskie friendly bump 🙏 |
ecordell
approved these changes
May 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes authzed/authzed-java#80
Tweaks the proto java output to have more ergonomic class names.
As a consequence, all types become top-level classes without nested outer classes.
E.g.
ExperimentalServiceOuterClass.BulkImportRelationshipsResponsebecomesBulkImportRelationshipsResponseThe generated output proto is less verbose, but clients will have to update their code accordingly. Given that the
authzed-javaSDK is < 1.0.0, we consider the API surface unstable and will proceed with the change.Improvements to Buf CI
The PR also changes how branches are made available. The
bufGitHub Action is updated to the latest version which supportsbug push --branchcommand. The branch will be pushed as a branch to BSR on every commit, and only as a draft when merged intomain.Rollback 7a8b818 once these changes have been published