Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate less verbose inner classes #81

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Mar 25, 2024

Fixes #80
See authzed/api#97

⚠️ This is a breaking change ⚠️

Tweaks the proto java output to have more ergonomic class names.
As a consequence, all types become top-level classes without nested outer classes.

@vroldanbet vroldanbet requested a review from a team as a code owner March 25, 2024 09:56
@vroldanbet vroldanbet changed the title changes to generator options uses draft of generator options changes Mar 25, 2024
@vroldanbet vroldanbet changed the title uses draft of generator options changes generate less verbose inner classes Mar 25, 2024
@vroldanbet vroldanbet self-assigned this Mar 25, 2024
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet force-pushed the changes-to-generator-options branch from 81084bb to a8ae90a Compare May 3, 2024 07:39
@vroldanbet vroldanbet added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 05767ee May 3, 2024
15 checks passed
@vroldanbet vroldanbet deleted the changes-to-generator-options branch May 3, 2024 07:41
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore "OuterClass" suffix in the generated java classes for better readability
2 participants