-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_debug_tools): fix unnecessary use of map #1040
fix(tier4_debug_tools): fix unnecessary use of map #1040
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
=====================================
Coverage 9.33% 9.33%
=====================================
Files 988 988
Lines 66676 66676
Branches 11591 11591
=====================================
Hits 6221 6221
Misses 55280 55280
Partials 5175 5175
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
@kenji-miyake @wep21 Could you check this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…n#1040) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
…n#1040) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
Fix for CI error of latest PRs.
#1037
#1036
I confirmed this PR worked well with the simple case where there is only one stop line.
FYI, it seems that the current implementation without this PR does not work well with python3 according to this article.
https://stackoverflow.com/questions/1303347/getting-a-map-to-return-a-list-in-python-3-x
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.