Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(behavior_velocity): add mutex for points subscription #1125

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix(behavior_velocity): add mutex for points subscription #1125

merged 1 commit into from
Jun 20, 2022

Conversation

TomohitoAndo
Copy link
Contributor

Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp

Description

Added mutex for compare map filtered points.
This fixes the bug that compare_map_filtered_pointcloud may have invalid value and this modules dies.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TomohitoAndo
fix(behavior_velocity): add mutex for points subscription
891f317 
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review June 17, 2022 09:06
@TomohitoAndo TomohitoAndo requested review from 0x126 and mkuri June 17, 2022 09:07
@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #1125 (891f317) into main (d52b662) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1125      +/-   ##
========================================
- Coverage   9.05%   9.04%   -0.01%     
========================================
  Files       1029    1029              
  Lines      69920   69931      +11     
  Branches   14597   14608      +11     
========================================
  Hits        6328    6328              
- Misses     58173   58182       +9     
- Partials    5419    5421       +2
Flag Coverage Δ *Carryforward flag
differential 5.08% <0.00%> (?)
total 9.03% <0.00%> (ø) Carriedforward from d52b662

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../include/scene_module/run_out/dynamic_obstacle.hpp 0.00% <ø> (ø)
...nner/src/scene_module/run_out/dynamic_obstacle.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52b662...891f317. Read the comment docs.

0x126
0x126 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 6cf2e58 into autowarefoundation:main Jun 20, 2022
@TomohitoAndo TomohitoAndo deleted the fix/add-mutex branch June 20, 2022 07:42
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jun 21, 2022
Merged
TomohitoAndo referenced this pull request in tier4/autoware.universe Jun 21, 2022
@TomohitoAndo
fix(behavior_velocity): add mutex for points subscription (#1125)
c806ead 
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo mentioned this pull request Jun 21, 2022
Merged
4 tasks
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@TomohitoAndo @boyali
fix(behavior_velocity): add mutex for points subscription (tier4#1125)
dea97ed 
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@TomohitoAndo @boyali
fix(behavior_velocity): add mutex for points subscription (tier4#1125)
a2da80f 
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@TomohitoAndo @boyali
fix(behavior_velocity): add mutex for points subscription (tier4#1125)
91db661 
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@TomohitoAndo @boyali
fix(behavior_velocity): add mutex for points subscription (tier4#1125)
7750a9d 
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 25, 2024
@saka1-s @satoshi-ota
@kminoda @TomohitoAndo @pre-commit-ci @maxime-clem @takeshi-iwanari @YoshiRi @soblin @YamatoAndo @0x126 @SakodaShintaro @mehmetdogru @rej55 @kyoichi-sugahara
feat: keep stop policy v0.11.2 (autowarefoundation#1125)
23d651f 
* feat(avoidance): keep stopping until all shift lines are registered

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(map_loader): display curbstone as marker array (autowarefoundation#4958)

display curbstone as marker array

Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* revert refactoring due to cherry-pick

* feat(ndt_scan_matcher): use glog (autowarefoundation#5465) (autowarefoundation#1031)

* feat(ndt_scan_matcher): use glog



* style(pre-commit): autofix

* update



* style(pre-commit): autofix

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(out_of_lane): improve reuse of previous decision (autowarefoundation#1017)

* Do not directly reuse a prev stop point but project it on the new path

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Improve reuse of the previously inserted stop point

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* Fix precision of inserted stop point

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

---------

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

* fix(system_monitor): output command line (autowarefoundation#5430) (autowarefoundation#1057)

* fix(system_monitor): output command line



* style(pre-commit): autofix

---------

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: pull tracking object merger from awf/main

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* feat(intersection): check path margin for overshoot vehicles on red light (autowarefoundation#5394) (autowarefoundation#1056)

Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fix(ndt_scan_matcher): delete diagnostics thread (autowarefoundation#5532)

Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>

* fix(ndt_scan_matcher): delete unmerged feature

* fix(ndt_scan_matcher): fixed a lock scope in update_ndt (autowarefoundation#5951)

Fixed the lock scope in update_ndt

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking (autowarefoundation#5842) (autowarefoundation#1075)

fix(utils): fix drivable area expansion logic for zebra zone

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bvp): traffic light state debug (autowarefoundation#1083)

Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>

* fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#5819) (autowarefoundation#1124)

* fix(traffic_light): stop if the traffic light signal timed out



* fix(traffic_light): fix README format



---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(mpc_lateral_controller): add debug info of qp solver (autowarefoundation#5459) (autowarefoundation#1098)

* add debug info of qp solver



* no info for EigenLeastSquareLLT



* return 0 in base class

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp>
Co-authored-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: Shinnosuke Hirakawa <shinnosuke.hirakawa@tier4.jp>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Mehmet Dogru <48479081+mehmetdogru@users.noreply.github.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 25, 2024
@saka1-s
feat: REVERT "keep stop policy v0.11.2" (autowarefoundation#1185)
1535305 
Revert "feat: keep stop policy v0.11.2 (autowarefoundation#1125)"

This reverts commit 23d651f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x126 0x126 0x126 approved these changes

@mkuri mkuri Awaiting requested review from mkuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomohitoAndo @0x126