-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(longitudinal_controller): add disable emergency option #1201
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1201 +/- ##
========================================
+ Coverage 9.59% 9.73% +0.14%
========================================
Files 1045 1045
Lines 71821 72037 +216
Branches 15590 15730 +140
========================================
+ Hits 6889 7011 +122
- Misses 58693 58714 +21
- Partials 6239 6312 +73
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(But I think it's a little strange that the controller send an emergency stop command but it doesn't change to emergency state. I think it is more appropriate to change the recovery conditions from emergency state depending on the parameters.)
Could you also update the parameter file in tier4_control_launch? |
* feat(longitudinal_controller): add disable emergency option Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add param Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* feat(longitudinal_controller): add disable emergency option Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add param Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* feat(longitudinal_controller): add disable emergency option Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add param Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…foundation#1201) * feat(longitudinal_controller): add disable emergency option Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add param Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* feat(longitudinal_controller): add disable emergency option Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * update readme Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add param Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
Add option to disable emergency in velocity_controller.
Now velocity_controller is stuck into the emergency state in some situations. It occurs even in manual driving, which blocks engaging while moving. Setting the emergency option to false solves the above issue.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.