Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): fix orientaion #1397

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 21, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Currently, insert point function cannot handle backward trajectory, and it inserts wrong direction if it's given the backward trajectory. In this PR, I add a new condition in the code to handle the reverse trajectory.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 changed the title fix orientation feat(motion_utils): fix orientaion Jul 21, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>
@takayuki5168 takayuki5168 self-requested a review July 21, 2022 11:42
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1397 (9923901) into main (b23f418) will increase coverage by 0.42%.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##            main    #1397      +/-   ##
=========================================
+ Coverage   9.91%   10.33%   +0.42%     
=========================================
  Files       1117     1117              
  Lines      77934    78627     +693     
  Branches   18087    18708     +621     
=========================================
+ Hits        7724     8127     +403     
- Misses     62678    62685       +7     
- Partials    7532     7815     +283     
Flag Coverage Δ *Carryforward flag
differential 10.00% <47.82%> (?)
total 9.89% <48.00%> (ø) Carriedforward from 5119843

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...tion_utils/test/src/trajectory/test_trajectory.cpp 29.14% <36.58%> (+4.15%) ⬆️
...ils/include/motion_utils/trajectory/trajectory.hpp 82.42% <89.28%> (+4.64%) ⬆️
planning/behavior_velocity_planner/src/node.cpp 0.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23f418...9923901. Read the comment docs.

@purewater0901 purewater0901 merged commit 9e7e7bf into autowarefoundation:main Jul 21, 2022
@purewater0901 purewater0901 deleted the feat/fix-insert-stop-point branch July 21, 2022 14:02
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants