-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_utils): fix orientaion #1397
feat(motion_utils): fix orientaion #1397
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
common/motion_utils/include/motion_utils/trajectory/trajectory.hpp
Outdated
Show resolved
Hide resolved
common/motion_utils/include/motion_utils/trajectory/trajectory.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1397 +/- ##
=========================================
+ Coverage 9.91% 10.33% +0.42%
=========================================
Files 1117 1117
Lines 77934 78627 +693
Branches 18087 18708 +621
=========================================
+ Hits 7724 8127 +403
- Misses 62678 62685 +7
- Partials 7532 7815 +283
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: yutaka purewater0901@gmail.com
Description
Currently, insert point function cannot handle backward trajectory, and it inserts wrong direction if it's given the backward trajectory. In this PR, I add a new condition in the code to handle the reverse trajectory.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.