Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pull_over): update pull over #150

Closed
wants to merge 50 commits into from

Conversation

1222-takeshi
Copy link

@1222-takeshi 1222-takeshi commented Oct 13, 2022

Description

This PR will be merged into beta/v0.5.4.
DO NOT MERGE

Related PR

PR List:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@1222-takeshi 1222-takeshi changed the title feat(pull_over): update pull over [WIP] feat(pull_over): update pull over Oct 13, 2022
@1222-takeshi 1222-takeshi force-pushed the feat/modify-pull-over branch 2 times, most recently from 3e984ca to 87c2bb0 Compare October 14, 2022 06:01
@1222-takeshi 1222-takeshi changed the base branch from beta/v0.5.2 to beta/v0.5.2-odaiba October 14, 2022 07:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.5.2-odaiba@c958cff). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             beta/v0.5.2-odaiba     #150   +/-   ##
=====================================================
  Coverage                      ?   10.92%           
=====================================================
  Files                         ?      691           
  Lines                         ?    56067           
  Branches                      ?    17151           
=====================================================
  Hits                          ?     6126           
  Misses                        ?    42512           
  Partials                      ?     7429           
Flag Coverage Δ
differential 10.92% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@1222-takeshi 1222-takeshi force-pushed the feat/modify-pull-over branch 5 times, most recently from c20bea4 to 5257274 Compare October 17, 2022 10:56
takayuki5168 and others added 20 commits October 18, 2022 18:42
* feat(motion_utils: add isDrivingForward function

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* implemented isDrivingForward

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* use isDrivingForward in each module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_autoware_utils): add setter/getter of longitudinal velocity

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* added test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
* fix(behavior_velocity_planner): remove unused util functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): use alias

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(motion_utils): remove path_with_lane_id.hpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
* feat(obstacle_stop_planner): add hold stop margin distance

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(obstacle_stop_planner): output distance info

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(obstacle_stop_planner): add param into config

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
* feat(obstacle_stop_planner): prevent from obstacle hunting

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(obstacle_stop_planner): add common parameter description

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(obstacle_stop_planner): fix bug

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
* feat(motion_utils): add new nearest index function

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add tests

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix rebase

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add README

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix for traffic nearest index

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix for markdownlint error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* fix(obstacle_stop_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…on#1652)

* fix(behavior_path_planner): pull_over shift parking

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* check lane_depature for each shift path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* change pull_over_velocity to 3.0

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(obstacle_cruise_planner): deal with backward driving

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor change

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* use isDrivingForward in motion_utils

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…towarefoundation#1731)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…j plugin (#1335)

* fix(tier4_planning_rviz_plugin): support backward driving in path_with_lane_id/path/trajectory plugin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add utils.hpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* docs(behavior_path_planner): update pull over docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…dation#1742)

* fix(behavior_path_planner): fix stop path for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use previous stop path when is has been generated

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
kosuke55 and others added 17 commits October 18, 2022 18:42
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…p is not ready (autowarefoundation#1824)

* fix(behavior_path_planner): fix pull_over dies when occupancy_grid_map is not ready

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/freespace_planning_algorithms/src/abstract_algorithm.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
…ll_over (autowarefoundation#1843)

* refactor(behavior_path_planner): use debug_marker of interface for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
… approval (autowarefoundation#1848)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1860)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…tion#1911)

* feat(behavior_path_planner): add pull_over base class

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* modify calculation of velocity abs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* modify from review

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add const

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* refactor shift pull over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* not use shared_ptr for lane_departure_checker

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/shift_pull_over.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix werror

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix build for main

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
…1871)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
…ation#1963)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…mpling (autowarefoundation#1969)

* fix(behavior_path_planner): shift pull over path distortion with resampling

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix from review

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
…1803)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@1222-takeshi 1222-takeshi changed the title [WIP] feat(pull_over): update pull over feat(pull_over): update pull over Oct 18, 2022
tkimura4 pushed a commit that referenced this pull request Oct 24, 2022
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
@tkimura4
Copy link
Collaborator

@1222-takeshi @kosuke55
#164
上記に置き換わるので、こちらはClose,であってます?

@kosuke55
Copy link

@tkimura4 @1222-takeshi
このPRのそのままのcommitも参考にしたいので、一旦 #164 で作業してました。
#164 で作業終わって動作確認できたら #164 closeで#150 の方にforce pushしようかなと思ってました。(ここcloseで#164 を正でも大丈夫です)

@tkimura4
Copy link
Collaborator

tkimura4 commented Oct 28, 2022

そのまま#164で良いと思います。
(そしたら、一連の作業終わったらこちらはCloseしますね. )

@kosuke55 kosuke55 closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants