Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(planning_debug_tools): add readme and add yaw to analyzer #1613

Merged
merged 4 commits into from
Aug 19, 2022
Merged

feat(planning_debug_tools): add readme and add yaw to analyzer #1613

merged 4 commits into from
Aug 19, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 18, 2022 •
edited by TakaHoribe
Loading

Description

add yaw and readme to debug tool

Related links

Tests performed

by psim and plot jugggler

experiment-2022-08-18_11.18.43.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3
feat(planning_debug_tools): add readme and add yaw to analyzer
dd4dcf1 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3
chore: remove verbose
2b8e7d1 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited
Loading

Codecov Report

Merging #1613 (9fa0a77) into main (803e278) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
- Coverage   10.76%   10.76%   -0.01%     
==========================================
  Files        1111     1111              
  Lines       78530    78551      +21     
  Branches    18554    18554              
==========================================
  Hits         8454     8454              
- Misses      61214    61235      +21     
  Partials     8862     8862
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.75% <0.00%> (ø) Carriedforward from 8b4158a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/planning_debug_tools/trajectory_analyzer.hpp 0.00% <0.00%> (ø)
..._debug_tools/include/planning_debug_tools/util.hpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TakaHoribe
update docs
8b4158a 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
TakaHoribe
TakaHoribe approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TakaHoribe
fix precommit
9fa0a77 
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) August 19, 2022 08:17
@taikitanaka3 taikitanaka3 merged commit 020c6d8 into main Aug 19, 2022
@taikitanaka3 taikitanaka3 deleted the feature/planning_debug_tools_add_readme_and_yaw branch August 19, 2022 08:31
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Aug 20, 2022
Merged
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 14, 2022
@taikitanaka3 @TakaHoribe
feat(planning_debug_tools): add readme and add yaw to analyzer (#1613)
19fed4b 
* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 14, 2022
@taikitanaka3 @TakaHoribe
feat(planning_debug_tools): add readme and add yaw to analyzer (#1613)
a31f8cd 
* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 14, 2022
@taikitanaka3 @TakaHoribe
@pre-commit-ci @takayuki5168
feat(planning_debug_tools): add planning debug tools (#120)
6d83e41 
* feat: add planning debug tools (#1362)

* add planning_debug_tools and trajectory_analyzer implementation

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change output topic name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add missing depend

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* ci(pre-commit): autofix

* update

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* move smoother tools to debug_tools

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(planning_debug_tools): add readme and add yaw to analyzer (#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* feat(planning_debug_tools): add accleration calculation (autowarefoundation#1782)

* chore: fix maintainer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(planning_debug_tools): add stop reason visualizer (autowarefoundation#1847)

* feat(planning_debug_tools): add stop reason visualizer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore : minor change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat: add stop reason text

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: add stop text

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc : add readme

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: fix indent

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(tier4_autoware_utils): add time argument in appendMarkerArray (#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@taikitanaka3 @TakaHoribe @boyali
feat(planning_debug_tools): add readme and add yaw to analyzer (tier4…
4010da9 
…#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @TakaHoribe @boyali
feat(planning_debug_tools): add readme and add yaw to analyzer (tier4…
3433b2e 
…#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @TakaHoribe @boyali
feat(planning_debug_tools): add readme and add yaw to analyzer (tier4…
7fc04ee 
…#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@taikitanaka3 @TakaHoribe
feat(planning_debug_tools): add readme and add yaw to analyzer (autow…
2ad898b 
…arefoundation#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@taikitanaka3 @TakaHoribe @boyali
feat(planning_debug_tools): add readme and add yaw to analyzer (tier4…
2c13dd0 
…#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taikitanaka3 @TakaHoribe