-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add update-codeownders-from-packages.yaml #1619
Conversation
FYI @xmfcx The test results of CODEOWNERS by TIER IV:
full-time/* @tier4/full-time-employee
miyake/* kenji.miyake@tier4.jp
saito/* @yukkysaito
taka/* @TakaHoribe |
So does this give people write permissions to edit the folders they are in? Example:
Assume takamasa.horibe@tier4.jp github account isn't in any of the github teams. And not registered in our repository. Does he gain write access to that package if he is on the CODEOWNERS list? Edit: Oh if he doesn't already have write access, it doesn't change anything. |
@xmfcx No, if the people listed CODEOWNERs don't have write permissions, I believe GitHub reports errors. |
.github/CODEOWNERS
Outdated
|
||
### Automatically generated from package.xml ### | ||
common/autoware_ad_api_msgs isamu.takagi@tier4.jp | ||
common/autoware_auto_common opensource@apex.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xmfcx @BonoloAWF By the way, does AWF have a common email like opensource@apex.ai
?
7697f50
to
bf25eca
Compare
bf25eca
to
9ab12fb
Compare
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
9ab12fb
to
52dde58
Compare
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Description
To automatically set reviewers and to ensure reviews by code owners, I'd like to introduce
CODEOWNERS
.https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
As it's troublesome to manually maintain
CODEOWNERS
for each package, I propose a way to generate it from maintainers inpackage.xml
.We have to update maintainers before merging this.
Related: #1610
Also, I'm planning to implement this in
autoware-github-actions
and use it in common for all repositories.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.