Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner, motion_utils): fix path shifter orientation #1633

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 19, 2022

Description

  • make insertOrientation function in motion_utils
  • Added orientation to shift path.

shift path

  • before

image

  • after

image

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/path_shifter_orientation branch from bafbbe7 to 3831cee Compare August 19, 2022 08:23
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1633 (29bb6a9) into main (fa25a2f) will increase coverage by 0.91%.
The diff coverage is 65.62%.

❗ Current head 29bb6a9 differs from pull request most recent head 3831cee. Consider uploading reports for the commit 3831cee to get more accurate results

@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
+ Coverage   10.77%   11.68%   +0.91%     
==========================================
  Files        1109     1109              
  Lines       78473    80058    +1585     
  Branches    18541    19567    +1026     
==========================================
+ Hits         8452     9355     +903     
- Misses      61165    61521     +356     
- Partials     8856     9182     +326     
Flag Coverage Δ *Carryforward flag
differential 11.72% <56.00%> (?)
total 10.75% <66.66%> (ø) Carriedforward from fa25a2f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/tier4_autoware_utils/geometry/geometry.hpp 95.96% <ø> (+0.44%) ⬆️
...th_planner/src/scene_module/utils/path_shifter.cpp 0.00% <0.00%> (ø)
...autoware_utils/test/src/geometry/test_geometry.cpp 49.37% <33.33%> (+7.12%) ⬆️
common/motion_utils/src/resample/resample.cpp 57.74% <80.00%> (+9.55%) ⬆️
...ils/include/motion_utils/trajectory/trajectory.hpp 78.60% <82.35%> (+0.49%) ⬆️
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
...onverter_node/radar_tracks_msgs_converter_node.cpp 0.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kosuke55 kosuke55 merged commit 7e06d47 into autowarefoundation:main Aug 19, 2022
@kosuke55 kosuke55 deleted the fix/path_shifter_orientation branch August 19, 2022 10:41
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
tier4#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
autowarefoundation#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
tier4#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
#1633)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants