feat(behavior_velocity_planner): hold stop margin distance in stop line module #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM（this will not affect duplicate route process） |
Codecov Report
@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 10.28% 10.28% -0.01%
==========================================
Files 1205 1205
Lines 86829 86862 +33
Branches 20079 20104 +25
==========================================
Hits 8931 8931
- Misses 68602 68631 +29
- Partials 9296 9300 +4
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ne module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
feat/hold-stop-margin-stop-line
branch
from
f9f9102
to
822f366
Compare
|
Resolve conflicts. |
planning/behavior_velocity_planner/src/scene_module/stop_line/scene.cpp
Outdated
Show resolved
Hide resolved
… length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
…ne module (tier4#1648) * feat(behavior_velocity_planner): hold stop margin distance in stop line module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): remove redundant offset term from arc length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ne module (tier4#1648) * feat(behavior_velocity_planner): hold stop margin distance in stop line module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): remove redundant offset term from arc length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ne module (tier4#1648) * feat(behavior_velocity_planner): hold stop margin distance in stop line module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): remove redundant offset term from arc length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
…ne module (autowarefoundation#1648) * feat(behavior_velocity_planner): hold stop margin distance in stop line module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): remove redundant offset term from arc length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
…ne module (tier4#1648) * feat(behavior_velocity_planner): hold stop margin distance in stop line module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): remove redundant offset term from arc length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
7 tasks
yn-mrse
referenced
this pull request
in tier4/autoware.universe
Jun 22, 2023
…ne module (#1648) * feat(behavior_velocity_planner): hold stop margin distance in stop line module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): remove redundant offset term from arc length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
This was referenced Jun 22, 2023
Merged
yn-mrse
referenced
this pull request
in tier4/autoware.universe
Jun 23, 2023
#612) * feat(behavior_velocity_planner): hold stop margin distance in stop line module (#1648) * feat(behavior_velocity_planner): hold stop margin distance in stop line module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): remove redundant offset term from arc length calculation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix: replace motion_utils to tier4_autoware_utils Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * feat: revive stopline_module functions Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * ci(pre-commit): autofix --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: satoshi-ota satoshi.ota928@gmail.com
Description
This PR is resubmission of #1433. (#1433 has been reverted in #1645)
Please see #1433 description.
test perform (
stop_duration_sec= 5.0[s],hold_stop_margin_distance= 2.0[m])simplescreenrecorder-2022-08-22_17.08.35.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.