Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): use common ego nearest search for lane_following #1686

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 25, 2022

Description

support u-turn or crossing path with lane_following module

issue
#1581

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 force-pushed the fix/behavior-path-nearest-ego2 branch 2 times, most recently from 54afd65 to 02d7e95 Compare August 26, 2022 02:38
@takayuki5168 takayuki5168 marked this pull request as ready for review August 26, 2022 04:24
@takayuki5168 takayuki5168 changed the title fix(behavior_path_planner): use common ego nearest search fix(behavior_path_planner): use common ego nearest search for lane_following Aug 26, 2022
@takayuki5168 takayuki5168 force-pushed the fix/behavior-path-nearest-ego2 branch 2 times, most recently from f590add to a98485e Compare August 29, 2022 04:20
@TakaHoribe
Copy link
Contributor

LGTM. Nice work.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1686 (5d7891c) into main (74e28ed) will decrease coverage by 0.15%.
The diff coverage is 11.25%.

@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   10.25%   10.10%   -0.16%     
==========================================
  Files        1204     1205       +1     
  Lines       86697    88450    +1753     
  Branches    20020    21259    +1239     
==========================================
+ Hits         8894     8935      +41     
- Misses      68541    70123    +1582     
- Partials     9262     9392     +130     
Flag Coverage Δ *Carryforward flag
differential 1.26% <10.34%> (?)
total 10.26% <8.45%> (+0.02%) ⬆️ Carriedforward from 087cc17

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...r_path_planner/scene_module/utils/path_shifter.hpp 0.00% <ø> (ø)
...lude/behavior_path_planner/turn_signal_decider.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.35% <0.00%> (+0.13%) ⬆️
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@takayuki5168 takayuki5168 force-pushed the fix/behavior-path-nearest-ego2 branch 2 times, most recently from 1fd8625 to abf0efd Compare August 30, 2022 01:15
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 6d425f8 into autowarefoundation:main Aug 30, 2022
@takayuki5168 takayuki5168 deleted the fix/behavior-path-nearest-ego2 branch August 30, 2022 07:02
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…llowing (autowarefoundation#1686)

* fix(behavior_path_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix todo's name

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…llowing (autowarefoundation#1686)

* fix(behavior_path_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix todo's name

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…llowing (autowarefoundation#1686)

* fix(behavior_path_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix todo's name

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…llowing (autowarefoundation#1686)

* fix(behavior_path_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix todo's name

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…llowing (autowarefoundation#1686)

* fix(behavior_path_planner): use common ego nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix todo's name

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants