-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change car size param in shape estimation #1709
feat: change car size param in shape estimation #1709
Conversation
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1709 +/- ##
=======================================
Coverage 10.71% 10.71%
=======================================
Files 1103 1103
Lines 78372 78372
Branches 18640 18640
=======================================
Hits 8397 8397
Misses 61062 61062
Partials 8913 8913
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yukihiro Saito yukky.saito@gmail.com
Description
In tutorial, there was a scene with
apollo instance segmentation based detection
anddetection by tracker
not working properly. The shape estimation threshold was too strict, so I change the param.Before
After
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.