Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change car size param in shape estimation #1709

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Aug 27, 2022

Signed-off-by: Yukihiro Saito yukky.saito@gmail.com

Description

In tutorial, there was a scene with apollo instance segmentation based detection and detection by tracker not working properly. The shape estimation threshold was too strict, so I change the param.

Before
Screenshot from 2022-08-27 23-56-02

After
Screenshot from 2022-08-28 02-16-01

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #1709 (6fa090a) into main (29c0536) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1709   +/-   ##
=======================================
  Coverage   10.71%   10.71%           
=======================================
  Files        1103     1103           
  Lines       78372    78372           
  Branches    18640    18640           
=======================================
  Hits         8397     8397           
  Misses      61062    61062           
  Partials     8913     8913           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.69% <0.00%> (ø) Carriedforward from 29c0536

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/shape_estimation/corrector/car_corrector.hpp 0.00% <0.00%> (ø)
...ception/shape_estimation/lib/filter/car_filter.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yukkysaito yukkysaito added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 28, 2022
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito merged commit 8792a93 into autowarefoundation:main Sep 7, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
yukke42 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 11, 2022
)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants