Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_smoother): add guard before interpolation #1752

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Sep 1, 2022

Description

Add guards before the linear interpolation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please wait for the scenario test

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1752 (0dc5062) into main (9944a2a) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   10.31%   10.25%   -0.06%     
==========================================
  Files        1207     1204       -3     
  Lines       87119    87096      -23     
  Branches    20076    20096      +20     
==========================================
- Hits         8982     8931      -51     
- Misses      68835    68868      +33     
+ Partials     9302     9297       -5     
Flag Coverage Δ *Carryforward flag
differential 3.85% <0.00%> (?)
total 10.24% <0.00%> (-0.06%) ⬇️ Carriedforward from 24f4bf1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...k_constrained_smoother/velocity_planning_utils.cpp 0.00% <0.00%> (ø)
.../motion_velocity_smoother/src/trajectory_utils.cpp 3.07% <0.00%> (-0.35%) ⬇️
...ocalization_initialization_state__type_support.cpp 0.00% <0.00%> (-50.00%) ⬇️
...ocalization_initialization_state__type_support.cpp 0.00% <0.00%> (-22.06%) ⬇️
...msgs/srv/initialize_localization__type_support.cpp 0.00% <0.00%> (-20.00%) ⬇️
...fastrtps/initialize_localization__type_support.cpp 2.81% <0.00%> (-19.02%) ⬇️
...ocalization_initialization_state__type_support.cpp 0.00% <0.00%> (-15.39%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901
Copy link
Contributor Author

image

Merge

@purewater0901 purewater0901 merged commit d38d66a into autowarefoundation:main Sep 1, 2022
@purewater0901 purewater0901 deleted the fix/add-guard-before-interpolation branch September 1, 2022 08:21
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…arefoundation#1752)

* feat(motion_velocity_smoother): add guard before interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…arefoundation#1752)

* feat(motion_velocity_smoother): add guard before interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…arefoundation#1752)

* feat(motion_velocity_smoother): add guard before interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…arefoundation#1752)

* feat(motion_velocity_smoother): add guard before interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…arefoundation#1752)

* feat(motion_velocity_smoother): add guard before interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* udpate

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants