-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_velocity_smoother): add guard before interpolation #1752
feat(motion_velocity_smoother): add guard before interpolation #1752
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please wait for the scenario test
Codecov Report
@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
- Coverage 10.31% 10.25% -0.06%
==========================================
Files 1207 1204 -3
Lines 87119 87096 -23
Branches 20076 20096 +20
==========================================
- Hits 8982 8931 -51
- Misses 68835 68868 +33
+ Partials 9302 9297 -5
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…arefoundation#1752) * feat(motion_velocity_smoother): add guard before interpolation Signed-off-by: yutaka <purewater0901@gmail.com> * udpate Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…arefoundation#1752) * feat(motion_velocity_smoother): add guard before interpolation Signed-off-by: yutaka <purewater0901@gmail.com> * udpate Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…arefoundation#1752) * feat(motion_velocity_smoother): add guard before interpolation Signed-off-by: yutaka <purewater0901@gmail.com> * udpate Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…arefoundation#1752) * feat(motion_velocity_smoother): add guard before interpolation Signed-off-by: yutaka <purewater0901@gmail.com> * udpate Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…arefoundation#1752) * feat(motion_velocity_smoother): add guard before interpolation Signed-off-by: yutaka <purewater0901@gmail.com> * udpate Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
Description
Add guards before the linear interpolation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.