-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lidar_centerpoint): fix has_twist condition #1753
fix(lidar_centerpoint): fix has_twist condition #1753
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
- Coverage 10.28% 10.28% -0.01%
==========================================
Files 1205 1205
Lines 86798 86803 +5
Branches 20067 20067
==========================================
Hits 8926 8926
- Misses 68712 68717 +5
Partials 9160 9160
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: scepter914 scepter914@gmail.com
Description
Fix the case objects has twist value and
has_twist=true
at the same time.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.