refactor(ekf_localizer): isolate state transition functions #1758
+284
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EKF class and add tests
IshitaTakeshi
requested review from
TakaHoribe,
kminoda and
YamatoAndo
as code owners
kminoda
added
the
component:localization
kminoda
requested changes
Sep 1, 2022
localization/ekf_localizer/include/ekf_localizer/state_transition.hpp
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1758 +/- ##
==========================================
+ Coverage 10.28% 10.31% +0.03%
==========================================
Files 1205 1207 +2
Lines 86798 87045 +247
Branches 20067 20371 +304
==========================================
+ Hits 8926 8983 +57
- Misses 68712 68875 +163
- Partials 9160 9187 +27
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
YamatoAndo
reviewed
Sep 2, 2022
localization/ekf_localizer/include/ekf_localizer/matrix_types.hpp
Outdated
Show resolved
Hide resolved
YamatoAndo
approved these changes
Sep 5, 2022
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Sep 28, 2022
…foundation#1758) * Isolate state transition functions from the EKF class and add tests
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…foundation#1758) * Isolate state transition functions from the EKF class and add tests
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…foundation#1758) * Isolate state transition functions from the EKF class and add tests
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
…foundation#1758) * Isolate state transition functions from the EKF class and add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Isolate the state transition functions from the EKF class and add tests
Related links
Tests performed
Add smoke tests for the state transition function and noise covariance
Add numerical tests for the state transition matrix
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.