Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interpolation): clean code #1766

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Sep 2, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Use interpolation utils to check the size of base keys and base values for zoh interpolation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 enabled auto-merge (squash) September 2, 2022 03:55
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1766 (fb46bc2) into main (fd0d776) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1766   +/-   ##
=======================================
  Coverage   10.38%   10.38%           
=======================================
  Files        1211     1211           
  Lines       87406    87413    +7     
  Branches    20282    20288    +6     
=======================================
+ Hits         9075     9081    +6     
  Misses      68849    68849           
- Partials     9482     9483    +1     
Flag Coverage Δ *Carryforward flag
differential 11.51% <100.00%> (?)
total 10.36% <ø> (ø) Carriedforward from fd0d776

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...polation/include/interpolation/zero_order_hold.hpp 58.33% <100.00%> (+11.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@purewater0901 purewater0901 merged commit a470a73 into autowarefoundation:main Sep 2, 2022
@purewater0901 purewater0901 deleted the feat/clean-interpolation branch September 2, 2022 05:10
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 7, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants