-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interpolation): use slerp for spherical_linear_interpolation #1769
fix(interpolation): use slerp for spherical_linear_interpolation #1769
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1769 +/- ##
=======================================
Coverage 10.38% 10.38%
=======================================
Files 1212 1212
Lines 87402 87402
Branches 20274 20274
=======================================
Hits 9081 9081
Misses 68842 68842
Partials 9479 9479
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…owarefoundation#1769) * fix(interpolation): use slerp for spherical_linear_interpolation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…owarefoundation#1769) * fix(interpolation): use slerp for spherical_linear_interpolation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…owarefoundation#1769) * fix(interpolation): use slerp for spherical_linear_interpolation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…owarefoundation#1769) * fix(interpolation): use slerp for spherical_linear_interpolation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…owarefoundation#1769) * fix(interpolation): use slerp for spherical_linear_interpolation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…owarefoundation#1769) * fix(interpolation): use slerp for spherical_linear_interpolation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
slerp
means spherical_linear_interpolation although we useslerp
for spline interpolation.In this PR, we will use
slerp
for spherical_linear_interpolation, andspline
for spline interpolationPre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.