Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interpolation): use slerp for spherical_linear_interpolation #1769

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 2, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

slerp means spherical_linear_interpolation although we use slerp for spline interpolation.
In this PR, we will use slerp for spherical_linear_interpolation, and spline for spline interpolation

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review September 2, 2022 10:24
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1769 (5f58020) into main (8c2080c) will not change coverage.
The diff coverage is 18.98%.

@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   10.38%   10.38%           
=======================================
  Files        1212     1212           
  Lines       87402    87402           
  Branches    20274    20274           
=======================================
  Hits         9081     9081           
  Misses      68842    68842           
  Partials     9479     9479           
Flag Coverage Δ *Carryforward flag
differential 12.37% <18.98%> (?)
total 10.37% <18.98%> (ø) Carriedforward from 8c2080c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ion/include/interpolation/spline_interpolation.hpp 28.57% <ø> (ø)
...e/interpolation/spline_interpolation_points_2d.hpp 83.33% <ø> (ø)
...ion_common/include/motion_common/motion_common.hpp 0.00% <0.00%> (ø)
.../motion_common/src/motion_common/motion_common.cpp 2.12% <0.00%> (ø)
...mmon/perception_utils/src/predicted_path_utils.cpp 49.05% <0.00%> (ø)
control/trajectory_follower/src/mpc_utils.cpp 58.25% <0.00%> (ø)
...eption/map_based_prediction/src/path_generator.cpp 0.00% <0.00%> (ø)
...th_planner/src/scene_module/utils/path_shifter.cpp 0.00% <0.00%> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <ø> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 81ce496 into autowarefoundation:main Sep 2, 2022
@takayuki5168 takayuki5168 deleted the fix/spline-and-slerp branch September 2, 2022 11:38
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…owarefoundation#1769)

* fix(interpolation): use slerp for spherical_linear_interpolation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…owarefoundation#1769)

* fix(interpolation): use slerp for spherical_linear_interpolation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…owarefoundation#1769)

* fix(interpolation): use slerp for spherical_linear_interpolation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 7, 2022
…owarefoundation#1769)

* fix(interpolation): use slerp for spherical_linear_interpolation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…owarefoundation#1769)

* fix(interpolation): use slerp for spherical_linear_interpolation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…owarefoundation#1769)

* fix(interpolation): use slerp for spherical_linear_interpolation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants