Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_fusion_to_detected_object): add message_filter to radar fusion #1779

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 5, 2022

Description

Add message sync to radar_fusion_to_detected_object package.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 5, 2022
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1779 (7e836f0) into main (9944a2a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
- Coverage   10.31%   10.30%   -0.01%     
==========================================
  Files        1207     1207              
  Lines       87119    87149      +30     
  Branches    20076    20076              
==========================================
  Hits         8982     8982              
- Misses      68835    68865      +30     
  Partials     9302     9302              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.29% <0.00%> (ø) Carriedforward from 9944a2a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...de/radar_object_fusion_to_detected_object_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scepter914 scepter914 changed the title fix(radar_fusion_to_detected_object) add message_filter to radar fusion fix(radar_fusion_to_detected_object): add message_filter to radar fusion Sep 6, 2022
@scepter914 scepter914 merged commit 06c3f55 into autowarefoundation:main Sep 6, 2022
@scepter914 scepter914 deleted the feature/radar_fusion_message_filter branch September 6, 2022 02:24
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ion (autowarefoundation#1779)

* fix(radar_fusion_to_detected_object) add message_filter to radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* delete comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion (autowarefoundation#1779)

* fix(radar_fusion_to_detected_object) add message_filter to radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* delete comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion (autowarefoundation#1779)

* fix(radar_fusion_to_detected_object) add message_filter to radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* delete comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ion (autowarefoundation#1779)

* fix(radar_fusion_to_detected_object) add message_filter to radar fusion

Signed-off-by: scepter914 <scepter914@gmail.com>

* delete comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants