Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_screen_capture_rviz_plugin): fix spell check #1790

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Sep 6, 2022

Signed-off-by: h-ohta hiroki.ota@tier4.jp

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1790 (cf5cba7) into main (165f29e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1790      +/-   ##
==========================================
- Coverage   10.32%   10.32%   -0.01%     
==========================================
  Files        1144     1144              
  Lines       75820    75845      +25     
  Branches    18737    18737              
==========================================
  Hits         7828     7828              
- Misses      59107    59132      +25     
  Partials     8885     8885              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.32% <0.00%> (ø) Carriedforward from 165f29e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_capture_rviz_plugin/src/screen_capture_panel.cpp 0.00% <0.00%> (ø)
...n_capture_rviz_plugin/src/screen_capture_panel.hpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta
Copy link
Contributor Author

h-ohta commented Sep 6, 2022

spell check is successful.

@h-ohta h-ohta merged commit 77555c5 into autowarefoundation:main Sep 6, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ation#1790)

* fix(tier4_screen_capture_rviz_plugin): fix spell check

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ation#1790)

* fix(tier4_screen_capture_rviz_plugin): fix spell check

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ation#1790)

* fix(tier4_screen_capture_rviz_plugin): fix spell check

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@h-ohta h-ohta deleted the refactor/spellcheck_screen_capture branch October 17, 2022 05:45
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ation#1790)

* fix(tier4_screen_capture_rviz_plugin): fix spell check

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants