-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): simplify duration conversion #2017
Conversation
Codecov ReportBase: 10.34% // Head: 10.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 10.34% 10.33% -0.01%
==========================================
Files 1162 1162
Lines 82730 82737 +7
Branches 19271 19277 +6
==========================================
Hits 8555 8555
- Misses 64915 64917 +2
- Partials 9260 9265 +5
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Does anyone know why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion#2017) Signed-off-by: scepter914 <scepter914@gmail.com>
Description
Simplify the syntax of duration conversion using
rclcpp::Duration::from_seconds
Related links
Tests performed
No tests have been performed yet
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.