Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): simplify duration conversion #2017

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

IshitaTakeshi
Copy link
Contributor

@IshitaTakeshi IshitaTakeshi commented Oct 4, 2022

Description

Simplify the syntax of duration conversion using rclcpp::Duration::from_seconds

Related links

Tests performed

No tests have been performed yet

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@IshitaTakeshi IshitaTakeshi added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 10.34% // Head: 10.33% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0f6679b) compared to base (6a6532b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
- Coverage   10.34%   10.33%   -0.01%     
==========================================
  Files        1162     1162              
  Lines       82730    82737       +7     
  Branches    19271    19277       +6     
==========================================
  Hits         8555     8555              
- Misses      64915    64917       +2     
- Partials     9260     9265       +5     
Flag Coverage Δ *Carryforward flag
differential 18.99% <0.00%> (?)
total 10.32% <0.00%> (ø) Carriedforward from 6a6532b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kminoda
Copy link
Contributor

kminoda commented Oct 7, 2022

Does anyone know why DCO test passes in this PR although the title does not seem to be valid?
(cc. @kenji-miyake ?)

@kenji-miyake
Copy link
Contributor

kenji-miyake commented Oct 7, 2022

@kminoda The title is checked in semantic-pull-request, not DCO.
Please refer to CI checks.

@IshitaTakeshi IshitaTakeshi changed the title Simplify duration conversion refactor(ekf_localizer): simplify duration conversion Oct 7, 2022
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IshitaTakeshi IshitaTakeshi merged commit 4be6931 into main Oct 13, 2022
@IshitaTakeshi IshitaTakeshi deleted the refactor/from-seconds branch October 13, 2022 04:55
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants