Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(raw_vehicle_cmd_converter): refactor csv loader #2074

Merged

Conversation

taikitanaka3
Copy link
Contributor

Description

  • refactor raw vehicle cmd converter
100% tests passed, 0 tests failed out of 5

Label Time Summary:
copyright     =   1.68 sec*proc (1 test)
cppcheck      =   0.38 sec*proc (1 test)
gtest         =   0.10 sec*proc (1 test)
lint_cmake    =   0.35 sec*proc (1 test)
linter        =   3.13 sec*proc (4 tests)
xmllint       =   0.71 sec*proc (1 test)

Total Test time (real) =   3.22 sec
Finished <<< raw_vehicle_cmd_converter [3.44s]

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 10.41% // Head: 10.44% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d1a07ef) compared to base (4be6931).
Patch coverage: 45.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
+ Coverage   10.41%   10.44%   +0.03%     
==========================================
  Files        1171     1171              
  Lines       83579    83648      +69     
  Branches    19578    19629      +51     
==========================================
+ Hits         8704     8738      +34     
- Misses      65369    65380      +11     
- Partials     9506     9530      +24     
Flag Coverage Δ *Carryforward flag
differential 5.49% <30.00%> (?)
total 10.39% <28.57%> (ø) Carriedforward from db6d493

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ehicle/raw_vehicle_cmd_converter/src/brake_map.cpp 22.22% <16.66%> (+4.36%) ⬆️
.../raw_vehicle_cmd_converter/src/steer_converter.cpp 37.66% <20.00%> (+3.81%) ⬆️
...ehicle/raw_vehicle_cmd_converter/src/accel_map.cpp 25.75% <42.85%> (+6.52%) ⬆️
...hicle/raw_vehicle_cmd_converter/src/csv_loader.cpp 51.28% <56.52%> (-2.57%) ⬇️
...r/include/raw_vehicle_cmd_converter/csv_loader.hpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super great

@taikitanaka3 taikitanaka3 merged commit 0af97ea into autowarefoundation:main Oct 15, 2022
@taikitanaka3 taikitanaka3 deleted the refactor/raw_vehicle_cmd_converter branch October 15, 2022 07:51
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
…ndation#2074)

* refactor(raw_vehicle_cmd_converter): refactor csv loader

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor: replace type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(raw_vehicle_cmd_converter): add get column index func

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor: saturation

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: scepter914 <scepter914@gmail.com>
taikitanaka3 added a commit to tier4/autoware.universe that referenced this pull request Dec 2, 2022
…ndation#2074)

* refactor(raw_vehicle_cmd_converter): refactor csv loader

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor: replace type

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(raw_vehicle_cmd_converter): add get column index func

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor: saturation

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants