Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): use setLongitudinalVelocity in insertStopPoint for PathPointWithLaneId #2206

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 3, 2022

Description

use setLongitudinalVelocity in insertStopPoint for PathPointWithLaneId

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…r PathPointWithLaneId

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 10.83% // Head: 10.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5f80beb) compared to base (3a69438).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2206   +/-   ##
=======================================
  Coverage   10.83%   10.84%           
=======================================
  Files        1179     1179           
  Lines       84840    84840           
  Branches    19982    19982           
=======================================
+ Hits         9195     9202    +7     
+ Misses      65925    65905   -20     
- Partials     9720     9733   +13     
Flag Coverage Δ *Carryforward flag
differential 11.20% <ø> (?)
total 10.81% <100.00%> (ø) Carriedforward from 3a69438

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ils/include/motion_utils/trajectory/trajectory.hpp 77.72% <100.00%> (ø)
system/default_ad_api/src/motion.cpp 13.11% <0.00%> (+11.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit 7d761a5 into autowarefoundation:main Nov 4, 2022
@kosuke55 kosuke55 deleted the feat/insert_stop_point_for_path_point_with_lane_id branch November 4, 2022 01:17
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…r PathPointWithLaneId (autowarefoundation#2206)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…r PathPointWithLaneId (autowarefoundation#2206)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Dec 1, 2022
…r PathPointWithLaneId (autowarefoundation#2206)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…r PathPointWithLaneId (autowarefoundation#2206)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…r PathPointWithLaneId (autowarefoundation#2206)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants