Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): pull over stop path #2207

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 3, 2022

Description

  • Constant length of stop path
  • Embed stop points accurately
  • Removed unused functions
  • Fix path candidate when not finding a safe path.

Related links

TIERIV INTERNAL LINK

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Nov 3, 2022

merge #2206 at first

@kosuke55 kosuke55 force-pushed the fix/pull_over_stop_path branch 2 times, most recently from 4b9bafa to 4e5b722 Compare November 4, 2022 01:22
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 11.09% // Head: 11.04% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (dbb2d1f) compared to base (7d761a5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
- Coverage   11.09%   11.04%   -0.06%     
==========================================
  Files        1202     1202              
  Lines       86168    86569     +401     
  Branches    20682    20943     +261     
==========================================
  Hits         9561     9561              
- Misses      66524    66910     +386     
- Partials    10083    10098      +15     
Flag Coverage Δ *Carryforward flag
differential 3.59% <0.00%> (?)
total 11.07% <0.00%> (ø) Carriedforward from d6b2582

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 26.31% <ø> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/pull_over/shift_pull_over.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 3.42% <0.00%> (-0.43%) ⬇️
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit b030c7f into autowarefoundation:main Nov 9, 2022
@kosuke55 kosuke55 deleted the fix/pull_over_stop_path branch November 9, 2022 03:06
@kosuke55
Copy link
Contributor Author

kosuke55 commented Nov 9, 2022

fixed bug in #2256

kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
)

* fix(behavior_path_planner): pull over stop path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix getExtendedCurrentLanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unused variables and fix deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
)

* fix(behavior_path_planner): pull over stop path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix getExtendedCurrentLanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unused variables and fix deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Dec 1, 2022
)

* fix(behavior_path_planner): pull over stop path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix getExtendedCurrentLanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unused variables and fix deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
)

* fix(behavior_path_planner): pull over stop path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix getExtendedCurrentLanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unused variables and fix deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
)

* fix(behavior_path_planner): pull over stop path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix getExtendedCurrentLanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unused variables and fix deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix typo

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants