-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): improve avoidance target filter #2282
feat(avoidance): improve avoidance target filter #2282
Conversation
Codecov ReportBase: 10.50% // Head: 10.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2282 +/- ##
==========================================
- Coverage 10.50% 10.38% -0.12%
==========================================
Files 1248 1248
Lines 90608 91606 +998
Branches 20728 21483 +755
==========================================
- Hits 9517 9515 -2
- Misses 70996 71934 +938
- Partials 10095 10157 +62
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
98cfc5c
to
cc5229b
Compare
update docs in the other PR. |
@TakaHoribe @rej55 @zulfaqar-azmi-t4 @mkuri Could you review this PR ? |
Nice! The result seems to be promising cap-.2022-11-16-01-15-28.mp4.mp4cap-.2022-11-16-01-16-55.mp4.mp4 |
…noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
cc5229b
to
b017da2
Compare
@TakaHoribe @zulfaqar-azmi-t4 @rej55 BaseLine (822/825) |
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM!
…2282) * feat(avoidance): use envelope polygon for measure against perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): use moving time for measure against perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(tier4_planning_launch): add new params for avoidance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): reserve marker array size Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…2282) * feat(avoidance): use envelope polygon for measure against perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): use moving time for measure against perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(tier4_planning_launch): add new params for avoidance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): reserve marker array size Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…2282) * feat(avoidance): use envelope polygon for measure against perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): use moving time for measure against perception noise Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(tier4_planning_launch): add new params for avoidance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): reserve marker array size Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
1. Use Envelope Polygon for measure against perception noise
Since object recognition results contain noise related to position ,orientation and boundary size, if the raw object recognition results are used in path generation, the avoidance path will be directly affected by the noise.
Therefore, in order to reduce the influence of the noise, avoidance module generate a envelope polygon for the avoidance target that covers it, and the avoidance path should be generated based on that polygon. The envelope polygons are generated so that they are parallel to the reference path and the polygon size is larger than the avoidance target (define by
object_envelope_buffer
). The position and size of the polygon is not updated as long as the avoidance target exists within that polygon.2. Use moving time for measure against perception noise
Since object recognition results contain noise related to object velocity, if only the object raw velocity are used in avoidance target filtering process, the results will be directly affected by the noise.
Therefore, even if a stopped object starts moving, it is judged to be stopped as long as it does not continue to move more than
threshold_time_object_is_moving
sec.Related links
Tests performed
envelope polygon is included in topic
/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/debug/avoidance
and the namespace istarget_objects_envelope_polygon
.Notes for reviewers
simplescreenrecorder-2022-11-14_11.07.20.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.