Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(avoidance): update documentation of avoidance module #2954

Merged
merged 7 commits into from
Mar 9, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 27, 2023

Description

This PR update avoidance module's logic description based on following PRs:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 27, 2023
@satoshi-ota satoshi-ota added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 27, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 27, 2023
@satoshi-ota satoshi-ota force-pushed the docs/avoidance branch 3 times, most recently from 60c463d to ed552ea Compare February 27, 2023 22:41
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f76977a) 11.99% compared to head (4874de0) 11.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2954   +/-   ##
=======================================
  Coverage   11.99%   11.99%           
=======================================
  Files        1314     1314           
  Lines       91445    91445           
  Branches    24240    24240           
=======================================
  Hits        10971    10971           
  Misses      69113    69113           
  Partials    11361    11361           
Flag Coverage Δ *Carryforward flag
differential 5.84% <0.00%> (?)
total 11.99% <ø> (+<0.01%) ⬆️ Carriedforward from f76977a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.15% <ø> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/scene_module_visitor.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
Copy link
Contributor Author

@tkimura4 @taikitanaka3 Could you review this docs PR? 🥺

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota
Copy link
Contributor Author

@taikitanaka3 @tkimura4 Thanks 😄

@satoshi-ota satoshi-ota merged commit 75e4bc7 into autowarefoundation:main Mar 9, 2023
@satoshi-ota satoshi-ota deleted the docs/avoidance branch March 9, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants