feat(tier4_localization_rviz_plugin): add pose history footprint #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
TakaHoribe
requested review from
isamu-takagi,
tkhmy,
yabuta and
a team
as code owners
github-actions
bot
added
component:common
TakaHoribe
added
the
component:tools
|
@TakaHoribe Can clear (= clear pose history) be realized by disabling the plugin? |
|
@TakaHoribe Could you add you as a maintainer? |
Codecov ReportBase: 10.48% // Head: 10.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
- Coverage 10.48% 10.47% -0.02%
==========================================
Files 1248 1250 +2
Lines 91222 91349 +127
Branches 21014 21014
==========================================
Hits 9565 9565
- Misses 71470 71597 +127
Partials 10187 10187
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@isamu-takagi OK. |
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
github-actions
bot
removed
the
component:tools
|
@isamu-takagi I updated the maintainer list. Please check it. |
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…owarefoundation#2387) * feat(tier4_localization_rviz_plugin): add pose history footprint Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused variables Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add maintainer Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…owarefoundation#2387) * feat(tier4_localization_rviz_plugin): add pose history footprint Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove unused variables Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add maintainer Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a plugin to visualize footprint from pose history as in this screenshot.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.