Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix pull out length to lane end #2692

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 19, 2023

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

Fix feat(behavior_path_planner): ignore pull out start near lane end
We need to check all pull_out lanes length, not just the end lane length

Related links

tier4 internal link
https://star4.slack.com/archives/CEV8XMJBV/p1674097368169939?thread_ts=1674040034.054809&cid=CEV8XMJBV

Tests performed

psim

work same as #2675

image

fix that a path is not generated in some case
before

image

after

image

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 11.38% // Head: 11.36% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (94c746b) compared to base (d15141e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   11.38%   11.36%   -0.02%     
==========================================
  Files        1277     1277              
  Lines       89240    89382     +142     
  Branches    23628    23728     +100     
==========================================
  Hits        10158    10158              
- Misses      68310    68446     +136     
- Partials    10772    10778       +6     
Flag Coverage Δ *Carryforward flag
differential 4.93% <0.00%> (?)
total 11.38% <0.00%> (ø) Carriedforward from d15141e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit fcacc80 into autowarefoundation:main Jan 19, 2023
@tkimura4 tkimura4 deleted the fix/pull_out_length_to_lane_end branch January 19, 2023 05:44
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 19, 2023
…foundation#2692)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 19, 2023
#251)

* fix(behavior_path_planner): fix pull out length to lane end (autowarefoundation#2692)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(behavior_path_planner): modify pull out stop path (autowarefoundation#2678)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…foundation#2692)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…foundation#2692)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
…ion#2692)

* remove Go PPA

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

docs(ansible/pre_commit): remove adding golang repository for humble (autowarefoundation#2837)

fix(docs): remove adding golang repository for humble

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

* rename galactic to humble

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: add ament_cmake fork (autowarefoundation#370)

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>

* revert(autoware.repos): revert "feat: add ament_cmake fork (autowarefoundation#370)" (autowarefoundation#3054)

This reverts commit 0d06dd3ce10ce4e4857822173954a48cb2e91b63.

* update hash of grid_map

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: remove grid_map from repos (autowarefoundation#2864)

* use Ubuntu 22.04 and CUDA 11.8

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* build(ansible/ros2_dev_tools): change ros2_dev_tools to follow humble documentation (autowarefoundation#3007)

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

build(ansible/ros2_dev_tools):  follow updated humble documentation (autowarefoundation#3020)

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* docs(ansible/cuda): update manual installation steps

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* tmp: use ubuntu:22.04 for cuda_base_image

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* tmp: add liburcu6 repository for CUDA 20.04 repository

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat(ansible/playbooks): update Ubuntu version

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants