Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_height_fitter): change map height fitter to library #2724

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jan 24, 2023

Description

Change map height fitter to library from node.

Related links

TIER IV INTERNAL LINK

Tests performed

Check the following for true/false of enable_partial_load in autoware_launch/config/map/pointcloud_map_loader.param.yaml

  • Initial pose by rviz (planning simulation launch)
  • Initial pose by GNSS (logging simulation launch)

Notes for reviewers

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:system System design and integration. (auto-assigned) labels Jan 24, 2023
@isamu-takagi isamu-takagi self-assigned this Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 11.75% // Head: 11.60% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (4f7634f) compared to base (55dc662).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 4f7634f differs from pull request most recent head 2a35610. Consider uploading reports for the commit 2a35610 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2724      +/-   ##
==========================================
- Coverage   11.75%   11.60%   -0.16%     
==========================================
  Files        1325     1320       -5     
  Lines       93059    92199     -860     
  Branches    25140    24425     -715     
==========================================
- Hits        10942    10702     -240     
+ Misses      70642    70325     -317     
+ Partials    11475    11172     -303     
Flag Coverage Δ *Carryforward flag
differential 4.34% <0.00%> (?)
total 11.62% <ø> (-0.14%) ⬇️ Carriedforward from 90bb1c3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e_initializer/src/pose_initializer/gnss_module.cpp 0.00% <0.00%> (ø)
map/map_height_fitter/src/map_height_fitter.cpp 0.00% <0.00%> (ø)
...lpers/ad_api_adaptors/src/initial_pose_adaptor.cpp 0.00% <0.00%> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <0.00%> (-21.43%) ⬇️
...zation/ekf_localizer/test/test_warning_message.cpp 54.54% <0.00%> (-4.28%) ⬇️
...nning_simulator/simple_planning_simulator_core.cpp 37.42% <0.00%> (-1.96%) ⬇️
...n_utils/test/src/trajectory/test_interpolation.cpp 17.34% <0.00%> (-0.82%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 7.98% <0.00%> (-0.38%) ⬇️
planning/route_handler/src/route_handler.cpp 11.45% <0.00%> (-0.11%) ⬇️
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)
... and 151 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi enabled auto-merge (squash) February 10, 2023 10:12
@isamu-takagi
Copy link
Contributor Author

Can you please review there packages?
@yabuta @tkhmy @kenji-miyake ad_api_adaptors
@YamatoAndo pose_initializer and map_height_fitter (extract the getting height function and move it to the library)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Planning Simulator, LGTM

@isamu-takagi isamu-takagi merged commit 0872ef8 into autowarefoundation:main Feb 22, 2023
@isamu-takagi isamu-takagi deleted the feat/map-height-fitter-library branch February 22, 2023 10:17
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…efoundation#2724)

* feat: move map height fitter

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: remove map height fitter dependency

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* apply to initial pose adaptor

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: get param from map loader

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: modify pose initializer

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: parameterize map loader name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* docs: update readme

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add debug code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Revert "feat: add debug code"

This reverts commit 7125034.

* feat: add map fit log

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…efoundation#2724)

* feat: move map height fitter

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: remove map height fitter dependency

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* apply to initial pose adaptor

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: get param from map loader

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: modify pose initializer

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: parameterize map loader name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* docs: update readme

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add debug code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Revert "feat: add debug code"

This reverts commit 7125034.

* feat: add map fit log

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
hayato-m126 added a commit to tier4/driving_log_replayer that referenced this pull request Jun 29, 2023
 Automatic correction of z-coordinates is not working, so I set the z value appropriately.
 autowarefoundation/autoware.universe#2724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:system System design and integration. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants