-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_height_fitter): change map height fitter to library #2724
feat(map_height_fitter): change map height fitter to library #2724
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportBase: 11.75% // Head: 11.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2724 +/- ##
==========================================
- Coverage 11.75% 11.60% -0.16%
==========================================
Files 1325 1320 -5
Lines 93059 92199 -860
Branches 25140 24425 -715
==========================================
- Hits 10942 10702 -240
+ Misses 70642 70325 -317
+ Partials 11475 11172 -303
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
This reverts commit 7125034.
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Can you please review there packages? |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
Co-authored-by: Yamato Ando <yamato.ando@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Planning Simulator, LGTM
…efoundation#2724) * feat: move map height fitter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove map height fitter dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * apply to initial pose adaptor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: get param from map loader Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify pose initializer Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: parameterize map loader name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * docs: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add debug code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Revert "feat: add debug code" This reverts commit 7125034. * feat: add map fit log Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…efoundation#2724) * feat: move map height fitter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove map height fitter dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * apply to initial pose adaptor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: get param from map loader Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: modify pose initializer Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: parameterize map loader name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * docs: update readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add debug code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Revert "feat: add debug code" This reverts commit 7125034. * feat: add map fit log Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Automatic correction of z-coordinates is not working, so I set the z value appropriately. autowarefoundation/autoware.universe#2724
Description
Change map height fitter to library from node.
Related links
TIER IV INTERNAL LINK
Tests performed
Check the following for true/false of
enable_partial_load
inautoware_launch/config/map/pointcloud_map_loader.param.yaml
Notes for reviewers
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.