Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): add calc interpolated point for path with lane id #2897

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 16, 2023

Description

Added calcInterpolatedPoint for PathWithLaneId

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 16, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 11.80% // Head: 11.82% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (4a395f4) compared to base (1fdcab3).
Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2897      +/-   ##
==========================================
+ Coverage   11.80%   11.82%   +0.01%     
==========================================
  Files        1319     1319              
  Lines       92309    92567     +258     
  Branches    24794    24961     +167     
==========================================
+ Hits        10899    10945      +46     
- Misses      70051    70149      +98     
- Partials    11359    11473     +114     
Flag Coverage Δ *Carryforward flag
differential 13.23% <28.57%> (?)
total 11.80% <ø> (ø) Carriedforward from 1fdcab3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_utils/test/src/trajectory/test_interpolation.cpp 18.15% <19.14%> (+0.81%) ⬆️
...mmon/motion_utils/src/trajectory/interpolation.cpp 96.15% <95.00%> (-0.73%) ⬇️
...stance_calculator/src/path_distance_calculator.cpp 0.00% <0.00%> (ø)
...based_prediction/src/map_based_prediction_node.cpp 0.00% <0.00%> (ø)
...c/pure_pursuit/pure_pursuit_lateral_controller.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit f2bad80 into autowarefoundation:main Feb 16, 2023
@takayuki5168 takayuki5168 deleted the feat/calc-interpolated-point-for-path branch February 16, 2023 16:33
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…autowarefoundation#2897)

* feat(motion_utils): add calc interpolated point for path with lane id

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* format

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…autowarefoundation#2897)

* feat(motion_utils): add calc interpolated point for path with lane id

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* format

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
xianglunkai pushed a commit to xianglunkai/autoware.universe that referenced this pull request Apr 3, 2023
…and apt packages (autowarefoundation#2897)

* refactor(setup): use pipx for Ansible to avoid conflicts between pip and apt packages

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add path

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants