-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): consider lane change in intersection based on associative ids #2899
feat(intersection): consider lane change in intersection based on associative ids #2899
Conversation
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Codecov ReportBase: 11.80% // Head: 11.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
==========================================
- Coverage 11.80% 11.74% -0.07%
==========================================
Files 1319 1319
Lines 92319 92826 +507
Branches 24794 25095 +301
==========================================
Hits 10899 10899
- Misses 70061 70549 +488
- Partials 11359 11378 +19
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the PR worked well with avoidance in the intersection
…ociative ids (autowarefoundation#2899) (NOTE: cherry-picked version for v0.41)
Description
Changed collision checking and some of the area generation based on the path, not the lane considering lane changing before / inside intersection.
Related links
Internal JIRA link: https://tier4.atlassian.net/browse/T4PB-25079
Tests performed
stuck vehicle detect area
Before this PR
After this PR
collision checking
working as before because
ego_lane
polygon(the orange polygon) is also generated from the path.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.