Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): consider lane change in intersection based on associative ids #2899

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 16, 2023

Description

Changed collision checking and some of the area generation based on the path, not the lane considering lane changing before / inside intersection.

Related links

Internal JIRA link: https://tier4.atlassian.net/browse/T4PB-25079

Tests performed

stuck vehicle detect area

Before this PR

image

After this PR

image

collision checking

image

working as before because ego_lane polygon(the orange polygon) is also generated from the path.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 11.80% // Head: 11.74% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e2963cb) compared to base (61a891f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2899      +/-   ##
==========================================
- Coverage   11.80%   11.74%   -0.07%     
==========================================
  Files        1319     1319              
  Lines       92319    92826     +507     
  Branches    24794    25095     +301     
==========================================
  Hits        10899    10899              
- Misses      70061    70549     +488     
- Partials    11359    11378      +19     
Flag Coverage Δ *Carryforward flag
differential 3.92% <0.00%> (?)
total 11.81% <ø> (+0.01%) ⬆️ Carriedforward from 76aa718

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/include/scene_module/intersection/manager.hpp 0.00% <ø> (ø)
...vior_velocity_planner/include/utilization/util.hpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 10.66% <0.00%> (-1.28%) ⬇️
...elocity_planner/src/scene_module/run_out/debug.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the PR worked well with avoidance in the intersection

@soblin soblin merged commit 3f07107 into autowarefoundation:main Feb 20, 2023
@soblin soblin deleted the fix/intersection-assoc-modules branch February 20, 2023 13:55
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
soblin added a commit to soblin/autoware.universe that referenced this pull request Mar 6, 2023
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants