Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(signal_processing): add Boost to build_export_depend #2917

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 20, 2023

Description

This makes sure that downstream packages have the correct dependencies (e.g. they can include boost/optional.hpp)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve requested review from takayuki5168 and a team as code owners February 20, 2023 09:57
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 20, 2023
@esteve esteve force-pushed the add-boost-build-export-depend-signal-processing branch from f3d239e to 551a9ba Compare February 20, 2023 09:57
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 11.79% // Head: 11.79% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (551a9ba) compared to base (ce82f3d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2917   +/-   ##
=======================================
  Coverage   11.79%   11.79%           
=======================================
  Files        1322     1322           
  Lines       92804    92789   -15     
  Branches    25004    24996    -8     
=======================================
  Hits        10944    10944           
+ Misses      70386    70371   -15     
  Partials    11474    11474           
Flag Coverage Δ *Carryforward flag
differential 3.47% <ø> (?)
total 11.79% <ø> (+<0.01%) ⬆️ Carriedforward from ce82f3d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.15% <ø> (+<0.01%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <ø> (ø)
...ne_module/lane_following/lane_following_module.cpp 0.00% <ø> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <ø> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@esteve esteve merged commit d65b3cc into autowarefoundation:main Feb 24, 2023
@esteve esteve deleted the add-boost-build-export-depend-signal-processing branch February 24, 2023 11:54
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…oundation#2917)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…oundation#2917)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants