Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): move module output interface definition #2921

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 21, 2023

Description

[DIFF]

move following struct definition to data_manager.hpp

  • TurnSignalInfo
  • BehaviorModuleOutput
  • CandidateOutput

[BACKGROUND]

I plan to add new framework and another scene_module_interface.hpp that supports new framework. Then, I avoid to define same struct in both of old and new scene_module_interface.hpp. Therefore, I want to move those definition from scene_module_interface.hpp.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 12.58% // Head: 12.58% // No change to project coverage 👍

Coverage data is based on head (be019e5) compared to base (f7f1d8d).
Patch coverage: 42.85% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2921   +/-   ##
=======================================
  Coverage   12.58%   12.58%           
=======================================
  Files        1222     1222           
  Lines       86989    86989           
  Branches    25011    25011           
=======================================
  Hits        10944    10944           
  Misses      64571    64571           
  Partials    11474    11474           
Flag Coverage Δ *Carryforward flag
differential 6.16% <42.85%> (?)
total 12.57% <ø> (-0.01%) ⬇️ Carriedforward from f7f1d8d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)
...lude/behavior_path_planner/turn_signal_decider.hpp 75.00% <ø> (-10.72%) ⬇️
...ner/src/scene_module/avoidance/avoidance_utils.cpp 1.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 21.42% <42.85%> (+21.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota enabled auto-merge (squash) February 21, 2023 06:00
@satoshi-ota satoshi-ota merged commit c5a1ccc into autowarefoundation:main Feb 21, 2023
@satoshi-ota satoshi-ota deleted the fix/move-module-output-struct branch February 21, 2023 06:27
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants