-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_perception_launch): remove unnecessary node #2941
fix(tier4_perception_launch): remove unnecessary node #2941
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
6e36d33
to
8df64eb
Compare
Codecov ReportBase: 11.53% // Head: 11.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 11.53% 11.78% +0.24%
==========================================
Files 1314 1324 +10
Lines 92723 92855 +132
Branches 24996 25011 +15
==========================================
+ Hits 10699 10946 +247
+ Misses 70782 70434 -348
- Partials 11242 11475 +233
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion#2941) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…tion#2941) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Description
This PR to remove
clustering/detected_object_feature_remover
from detection architecture since it becomes unnecessary after PR #2845 is merged.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.