Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): remove unnecessary node #2941

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Feb 24, 2023

Description

This PR to remove clustering/detected_object_feature_remover from detection architecture since it becomes unnecessary after PR #2845 is merged.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 24, 2023
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the fix/roi_cluster_fusion_remove_unuse_node branch from 6e36d33 to 8df64eb Compare February 24, 2023 08:25
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 11.53% // Head: 11.78% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (6e36d33) compared to base (d32dc46).
Patch has no changes to coverable lines.

❗ Current head 6e36d33 differs from pull request most recent head 8df64eb. Consider uploading reports for the commit 8df64eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2941      +/-   ##
==========================================
+ Coverage   11.53%   11.78%   +0.24%     
==========================================
  Files        1314     1324      +10     
  Lines       92723    92855     +132     
  Branches    24996    25011      +15     
==========================================
+ Hits        10699    10946     +247     
+ Misses      70782    70434     -348     
- Partials    11242    11475     +233     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 11.78% <ø> (+0.24%) ⬆️ Carriedforward from 873666f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <0.00%> (-21.43%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 8.36% <0.00%> (ø)
...ing/obstacle_avoidance_planner/src/utils/utils.cpp 10.59% <0.00%> (ø)
...stacle_avoidance_planner/src/utils/debug_utils.cpp 0.00% <0.00%> (ø)
...tacle_stop_planner/src/adaptive_cruise_control.cpp 0.00% <0.00%> (ø)
...ils/include/motion_utils/trajectory/trajectory.hpp 75.12% <0.00%> (ø)
...e_initializer/src/pose_initializer/gnss_module.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...lpers/ad_api_adaptors/src/initial_pose_adaptor.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
... and 80 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@badai-nguyen badai-nguyen marked this pull request as ready for review February 24, 2023 09:50
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit 6158a6f into autowarefoundation:main Feb 24, 2023
@badai-nguyen badai-nguyen deleted the fix/roi_cluster_fusion_remove_unuse_node branch February 24, 2023 10:12
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants